Skip to content

WN: 10prev7 OpenAPI #35925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 12, 2025
Merged

WN: 10prev7 OpenAPI #35925

merged 8 commits into from
Aug 12, 2025

Conversation

wadepickett
Copy link
Contributor

@wadepickett wadepickett commented Aug 11, 2025 •
edited
Loading

Contributes to #35824

Updates for What's New for all OpenAPI changes for Preview 7 except for responseDescProducesResponseType.md is already being updated on PR #35752

I also added Enhanced validation for classes and records mention since it was the last of a group that Mike asked for, even though it is not OpenAPI related in: includes\enhance-validation-classes-records.md

@wadepickett wadepickett self-assigned this Aug 11, 2025
@wadepickett wadepickett mentioned this pull request Aug 11, 2025
Open
@wadepickett wadepickett marked this pull request as ready for review August 11, 2025 21:31
@wadepickett wadepickett requested a review from tdykstra August 11, 2025 21:32
@guardrex

This comment was marked as resolved.

Sign in to view
@wadepickett
Copy link
Contributor Author

responseDescProducesResponseType.md is already being updated on #35752, so I think we should either make updates here and close that one or move the updates there and remove them from this PR. Either way is fine.

Thanks @guardrex, I missed that thread that was separate from the What's New tracking issue. I'll note that you are handling that one in the What's New issue.

I'll pull out the mention I have here in this PR guided originally by Mike.

@guardrex
Copy link
Collaborator

I'll add that para ...

This functionality is supported in both API controllers and Minimal APIs. For Minimal APIs, the Description property is correctly set even when the attribute’s type and the inferred return type aren't an exact match.

... to his PR with the XREFs.

@wadepickett
Copy link
Contributor Author

xrefs: thanks for catching that, I blanked on it as I have been racing through this stuff. I certainly should have used xrefs.

@wadepickett wadepickett requested a review from guardrex August 11, 2025 21:57
guardrex
guardrex approved these changes Aug 12, 2025
View reviewed changes
Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some minor suggestions.

@wadepickett wadepickett merged commit 80c876b into main Aug 12, 2025
3 checks passed
@wadepickett wadepickett deleted the wadepickett/35906WhatsNewv10prev7OpenAPIUpgrade20 branch August 12, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

@guardrex guardrex guardrex approved these changes

Assignees

@wadepickett wadepickett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wadepickett @guardrex @tdykstra